-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc tauri fixes #503
Misc tauri fixes #503
Conversation
Otherwise it fails to build at all
LogicalSize is what we want, to make the app work properly on retina displays
50e8864
to
a686d12
Compare
@@ -49,6 +54,9 @@ fn main() { | |||
|
|||
println!("Pomatez is ready"); | |||
} | |||
RunEvent::ExitRequested { api, .. } => { | |||
api.prevent_exit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I'd already implemented the closing to tray in the settings?
Or are you talking about the Mac's close to tray? If so, you'll need to add a check or a compiler flag to make sure it doesn't do this on Windows as that is not the expected behavior.
Ill be honest I've only lightly tested it on a very old mac so id just like to outline the current behavior vs expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this implemented for these other platforms on tauri? I cannot find any code that handles this for any platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe they expect apps to handle it themselves, I tauri just provides a platform to make apps. The same as electron doesn't implement this behavior either.
I believe these have been fixed by my changes already so I'm closing this for now. |
There's some rustfmt in there as well.
I can split these changes up into separate PRs as needed, and if you wish I could get rid of the rustfmt diffs. Let me know.